jayasankar/login-app

AI Summary: This GitHub issue identifies the use of a deprecated FastAPI event handler, `@app.on_event("startup")`, in `main.py:17`. It notes that this API is deprecated in FastAPI 0.115.6 and provides a clear solution: migrating to the `lifespan` asynchronous context manager. The issue includes a code snippet demonstrating the correct implementation for handling startup logic.

AI Summary: The `csv_loader.py` script is missing error handling for malformed CSV lines. Specifically, `line.split(",", 1)` will raise a `ValueError` if a line does not contain a comma, leading to unexpected crashes. The proposed solution is to validate that the `split` operation produces exactly two values before attempting to unpack them.

AI Summary: The function at `csv_loader.py:53` has inconsistent return behavior. It always returns a module-level `credentials_map`, but silently catches exceptions and returns an empty dictionary on error. This design masks potential failures, preventing callers from knowing whether the loading process succeeded or failed.